Discussion:
[doctrine-user] xml custom-id-generator class attribute type nmtoken
MetaAbstract
2017-11-04 12:48:21 UTC
Permalink
Hi,
I define custom id generator and can't define class for custom id generator
because class is nmtoken type not string. XSD checker give error for class
name.

<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator
class="MetaAbstract\Documents\Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Marco Pivetta
2017-11-04 13:19:56 UTC
Permalink
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Артем Мельчук
2017-11-04 14:51:32 UTC
Permalink
it's here:
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>

so we just need to change it's to xs:string

Patch is you mean create new version of doctrine-mapping.xsd and make diff
for them and attach it's here?
What kind of test you need?


i made


*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.




С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/
topic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Marco Pivetta
2017-11-04 16:38:42 UTC
Permalink
Hey АртеЌ,

A test would be an addition to
https://github.com/doctrine/doctrine2/blob/a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php

You have to write a mapping with a `custom-id-generator` that breaks on the
current version of the ORM, and that is fixed once you apply your patch to
the XSD :-)

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/
Post by Артем Мельчук
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>
so we just need to change it's to xs:string
Patch is you mean create new version of doctrine-mapping.xsd and make diff
for them and attach it's here?
What kind of test you need?
i made
*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Артем Мельчук
2017-11-04 17:30:11 UTC
Permalink
Hi, Macrco!
I understood workflow. After next week will try to make this. It's ok?
I am not very familiar with git ( prefer svn) and phpunit(prefer clear code
and architecture), but it's good case for practice in this area.


С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Hey АртеЌ,
A test would be an addition to https://github.com/doctrine/doctrine2/blob/
a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/Doctrine/Tests/ORM/Mapping/
XmlMappingDriverTest.php
You have to write a mapping with a `custom-id-generator` that breaks on
the current version of the ORM, and that is fixed once you apply your patch
to the XSD :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>
so we just need to change it's to xs:string
Patch is you mean create new version of doctrine-mapping.xsd and make
diff for them and attach it's here?
What kind of test you need?
i made
*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/
topic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Marco Pivetta
2017-11-04 17:32:01 UTC
Permalink
Let us know if we can help out in getting started - contributing to OSS
from a simple patch is the best way to start :-)

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/
Post by Артем Мельчук
Hi, Macrco!
I understood workflow. After next week will try to make this. It's ok?
I am not very familiar with git ( prefer svn) and phpunit(prefer clear
code and architecture), but it's good case for practice in this area.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Hey АртеЌ,
A test would be an addition to https://github.com/doctrine/do
ctrine2/blob/a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/
Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php
You have to write a mapping with a `custom-id-generator` that breaks on
the current version of the ORM, and that is fixed once you apply your patch
to the XSD :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>
so we just need to change it's to xs:string
Patch is you mean create new version of doctrine-mapping.xsd and make
diff for them and attach it's here?
What kind of test you need?
i made
*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Артем Мельчук
2017-11-04 17:45:27 UTC
Permalink
Thx a lot! What is the best channel for contributor? IRC? This is user
support as i think

С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Let us know if we can help out in getting started - contributing to OSS
from a simple patch is the best way to start :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
Hi, Macrco!
I understood workflow. After next week will try to make this. It's ok?
I am not very familiar with git ( prefer svn) and phpunit(prefer clear
code and architecture), but it's good case for practice in this area.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Hey АртеЌ,
A test would be an addition to https://github.com/doctrine/do
ctrine2/blob/a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/
Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php
You have to write a mapping with a `custom-id-generator` that breaks on
the current version of the ORM, and that is fixed once you apply your patch
to the XSD :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>
so we just need to change it's to xs:string
Patch is you mean create new version of doctrine-mapping.xsd and make
diff for them and attach it's here?
What kind of test you need?
i made
*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it,
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/
topic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Marco Pivetta
2017-11-04 17:57:19 UTC
Permalink
Probably IRC, yes, although you can refer to
https://yangsu.github.io/pull-request-tutorial/ to get started

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/
Post by Артем Мельчук
Thx a lot! What is the best channel for contributor? IRC? This is user
support as i think
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Let us know if we can help out in getting started - contributing to OSS
from a simple patch is the best way to start :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
Hi, Macrco!
I understood workflow. After next week will try to make this. It's ok?
I am not very familiar with git ( prefer svn) and phpunit(prefer clear
code and architecture), but it's good case for practice in this area.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Hey АртеЌ,
A test would be an addition to https://github.com/doctrine/do
ctrine2/blob/a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/
Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php
You have to write a mapping with a `custom-id-generator` that breaks on
the current version of the ORM, and that is fixed once you apply your patch
to the XSD :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>
so we just need to change it's to xs:string
Patch is you mean create new version of doctrine-mapping.xsd and make
diff for them and attach it's here?
What kind of test you need?
i made
*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it,
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in
the Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Артем Мельчук
2017-11-05 11:18:57 UTC
Permalink
Thx a lot. I will.

С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Probably IRC, yes, although you can refer to
https://yangsu.github.io/pull-request-tutorial/ to get started
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
Thx a lot! What is the best channel for contributor? IRC? This is user
support as i think
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Let us know if we can help out in getting started - contributing to OSS
from a simple patch is the best way to start :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
Post by Артем Мельчук
Hi, Macrco!
I understood workflow. After next week will try to make this. It's ok?
I am not very familiar with git ( prefer svn) and phpunit(prefer clear
code and architecture), but it's good case for practice in this area.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Hey АртеЌ,
A test would be an addition to https://github.com/doctrine/do
ctrine2/blob/a82f6c5725cb31348eae0b4414e8992b1400ba30/tests/
Doctrine/Tests/ORM/Mapping/XmlMappingDriverTest.php
You have to write a mapping with a `custom-id-generator` that breaks
on the current version of the ORM, and that is fixed once you apply your
patch to the XSD :-)
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On Sat, Nov 4, 2017 at 3:51 PM, АртеЌ Мельчук <
Post by Артем Мельчук
<xs:complexType name="custom-id-generator">
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded"
namespace="##other"/>
</xs:sequence>
<xs:attribute name="class" type="xs:NMTOKEN" use="required" />
</xs:complexType>
so we just need to change it's to xs:string
Patch is you mean create new version of doctrine-mapping.xsd and make
diff for them and attach it's here?
What kind of test you need?
i made
*diff doctrine-mapping-old.xsd doctrine-mapping.xsd >
doctrine-mapping.xsd.patch*
my xml is now valid against corrected xsd. files and patch in attachment.
С УважеМОеЌ, Мельчук АртеЌ.
Post by Marco Pivetta
Send a patch with a test 👍
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator class="MetaAbstract\Documents\
Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it,
.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in
the Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it,
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google
Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/to
pic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to a topic in the
Google Groups "doctrine-user" group.
To unsubscribe from this topic, visit https://groups.google.com/d/
topic/doctrine-user/q9aHfy5l30M/unsubscribe.
To unsubscribe from this group and all its topics, send an email to
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
f***@spectrm.de
2017-12-12 14:53:17 UTC
Permalink
I have the same problem for weeks! +1 for having a fix here.
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator
class="MetaAbstract\Documents\Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
MetaAbstract
2017-12-15 09:34:08 UTC
Permalink
Thx!))))
Hope i will make little commit to project soon.
Post by f***@spectrm.de
I have the same problem for weeks! +1 for having a fix here.
Post by MetaAbstract
Hi,
I define custom id generator and can't define class for custom id
generator because class is nmtoken type not string. XSD checker give error
for class name.
<orm:id name="DUUID" type="string" length="33">
<orm:generator strategy="CUSTOM"></orm:generator>
<orm:custom-id-generator
class="MetaAbstract\Documents\Utils\DUUID"></orm:custom-id-generator>
</orm:id>
I need to correct xsd or i am don't understand something?
--
You received this message because you are subscribed to the Google Groups "doctrine-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to doctrine-user+***@googlegroups.com.
To post to this group, send email to doctrine-***@googlegroups.com.
Visit this group at https://groups.google.com/group/doctrine-user.
For more options, visit https://groups.google.com/d/optout.
Loading...